mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52184: Added 'os::spawn()' to stout as 'argv' counterpart to 'os::system()'.
Date Fri, 23 Sep 2016 02:46:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52184/#review150125
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 23, 2016, 2:03 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52184/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6235
>     https://issues.apache.org/jira/browse/MESOS-6235
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'os::spawn()' to stout as 'argv' counterpart to 'os::system()'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/shell.hpp df8fb4c94d44067038eacd8dc3bb4d566c8df836

>   3rdparty/stout/include/stout/os/windows/shell.hpp 8fb48c1c4178485cac2934833b5c440d873e4fc4

> 
> Diff: https://reviews.apache.org/r/52184/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo make check
> 
> I also had someone make sure it at least compiled for windows.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message