mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <>
Subject Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.
Date Thu, 22 Sep 2016 19:49:27 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 22, 2016, 7:49 p.m.)

Review request for mesos and Vinod Kone.


Updated per feedback:
- Split apart the tests.
- Avoid inconsistent quoting of ContainerID (no need to quote but I left in one case of quoting).
- Updated a log message for consistency.
- Explained why the test needs to expect a call to `Containerizer::containers`.

Bugs: MESOS-2449

Repository: mesos


This patch adds the wiring for the *_NESTED_CONTAINER calls,
including validation and calling into the containerizer.

Diffs (updated)

  src/slave/http.cpp 73135be5651300e1fe7a20428aeb034392f915ed 
  src/tests/api_tests.cpp 26f99f7c337fbbc5278d1b30d3d5c8f659ddf5ca 



Added a test that mocks out the containerizer.


Benjamin Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message