mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.
Date Thu, 22 Sep 2016 14:28:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/#review149998
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/reap.hpp (line 53)
<https://reviews.apache.org/r/40413/#comment217807>

    Single space between sentences?



3rdparty/libprocess/src/reap.cpp (line 118)
<https://reviews.apache.org/r/40413/#comment217809>

    Is there a reason to have spaces in `> > >` here? We generally do not use spaces
AFAICT.


- Greg Mann


On Aug. 10, 2016, 8:17 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40413/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3934
>     https://issues.apache.org/jira/browse/MESOS-3934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The reaper singleton must be unified with `process::initialize` so 
> that it also falls under the scope of reinitialization.  The singleton 
> must also not be guarded by `Once`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/reap.hpp d7e0fa381df63a9ca7d438d5cea0631e1b0ec7ee

>   3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 
>   3rdparty/libprocess/src/reap.cpp 5fc2a4d67a3a6fe56005fc2c2d16d4983d53b83a 
> 
> Diff: https://reviews.apache.org/r/40413/diff/
> 
> 
> Testing
> -------
> 
> Tests done in a subsequent review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message