mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52086: Cleaned up header includes in stout.
Date Thu, 22 Sep 2016 10:38:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52086/#review149979
-----------------------------------------------------------




3rdparty/stout/include/stout/os/posix/mkdtemp.hpp (line 20)
<https://reviews.apache.org/r/52086/#comment217780>

    To be fully correct, we should `#include <cstring>` and prepend function names with
`std`. Unfortunately, this is not what we do in most cases.



3rdparty/stout/include/stout/os/posix/mkdtemp.hpp (line 21)
<https://reviews.apache.org/r/52086/#comment217782>

    Why do we need this one?


- Alexander Rukletsov


On Sept. 22, 2016, 9:58 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52086/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:58 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up header includes in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/mktemp.hpp 2e35c731aac9885024d64d9fd03c221e96ff3025

>   3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 31acbd406c7d447d6f141201c0cfa153d948ef9f

>   3rdparty/stout/include/stout/os/raw/argv.hpp 3ac62169be22eebaa56ec1a3b7cf1d0007b17870

> 
> Diff: https://reviews.apache.org/r/52086/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX and Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message