mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.
Date Thu, 22 Sep 2016 05:55:07 GMT


> On Sept. 20, 2016, 11:48 p.m., Vinod Kone wrote:
> > src/slave/validation.cpp, lines 117-127
> > <https://reviews.apache.org/r/52100/diff/1/?file=1506602#file1506602line117>
> >
> >     so `UUID::fromBytes()` (used for status update uuids) doesn't impose a restriction
on the version but we want to impose version restriction here?

My thinking is that since it isn't reasonable to use other versions:

* 1 has some uniqueness issues now that processors have become faster, and so has some workarounds.
* 2 is not explicitly defined in the UUID specficiation.
* 3 is based on names within a namespace, not clear how that could be applicable here.
* 5 has the same issue as 3, but uses SHA-1 instead of MD5.

Rather than have the user have to work this out, we might as well require version 4 and relax
it if a use case arises (doubtful). IMHO if we want executors to generate UUIDs for status
updates, we should probably also require version 4.


> On Sept. 20, 2016, 11:48 p.m., Vinod Kone wrote:
> > src/slave/validation.cpp, lines 117-127
> > <https://reviews.apache.org/r/52100/diff/1/?file=1506602#file1506602line117>
> >
> >     I would flip the order of these two.

Ah yes, this evolved poorly.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52100/#review149761
-----------------------------------------------------------


On Sept. 20, 2016, 9:28 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52100/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2449
>     https://issues.apache.org/jira/browse/MESOS-2449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f 
>   src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
>   src/tests/slave_validation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52100/diff/
> 
> 
> Testing
> -------
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message