mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.
Date Thu, 22 Sep 2016 00:35:03 GMT


> On Aug. 11, 2016, 6:16 p.m., Michael Park wrote:
> > Hi Klaus, could you explain what the motivation is for this patch?
> > Currently, your analysis seems correct that reserved resources are always non-revocable.
> > However, the current code seems that it'll be more future-proof.
> > That is, even after reserved resources becomes revocable it would remain correct.
> > 
> > Anyway, I'm curiuos as to why this patch is being suggested. Thanks!
> 
> Klaus Ma wrote:
>     Try to improve the performance by avoid unnecessary operation :).
> 
> Michael Park wrote:
>     That would've been my guess. Are there any numbers to support the patch?
> 
> Klaus Ma wrote:
>     The number dependent on cases; anyway, I'll append some number for it.
> 
> Guangya Liu wrote:
>     I think that this will not impact performance much as we always need two resources
operations here: `nonRevocable()` and `+` , the time consumed in those two calls should be
same even with this fix.
> 
> Michael Park wrote:
>     Hey Klaus, Just curious if you've determined whether or not this actually has notable
improvements?
>     If so, could you post some numbers? If not, could you discard the review?

@Michael, let's discard this for now. I'm working on other tasks, wil re-open it when the
numbers is ready.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45081/#review145489
-----------------------------------------------------------


On April 19, 2016, 12:01 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45081/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 12:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4988
>     https://issues.apache.org/jira/browse/MESOS-4988
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allocator will only allocate non-revocable resources to satify quota. As the reserved
resources can not be revocable, it's not necessary to call `nonRevocable()` for reserved resources.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32

> 
> Diff: https://reviews.apache.org/r/45081/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message