mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag.
Date Wed, 21 Sep 2016 20:13:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52096/#review149886
-----------------------------------------------------------




src/slave/container_loggers/lib_logrotate.cpp (lines 142 - 145)
<https://reviews.apache.org/r/52096/#comment217644>

    Based on the comment I left in the previous review, you will end up changing how change
the user is saved.
    
    ```
    Option<std::string> user = None();
    if (executorInfo.has_command() &&
        executorInfo.command().has_user()) {
      user = executorInfo.command().user();
    }
    ```
    (Note the differences in this example's spacing and your spacing.)



src/slave/container_loggers/lib_logrotate.cpp (line 178)
<https://reviews.apache.org/r/52096/#comment217645>

    Similarly, this will change to 
    ```
    outFlags.user = user;
    ```
    
    Ditto with `errFlags`.


- Joseph Wu


On Sept. 20, 2016, 8:54 p.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52096/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 8:54 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Read  user details passed in executorInfo and assign it to user flag.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/lib_logrotate.cpp 1c170e5d11ef31d468b200c2c4cbd27abeeb418a

> 
> Diff: https://reviews.apache.org/r/52096/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message