mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 52129: Windows: Fixed subprocess and setsid compilation errors.
Date Wed, 21 Sep 2016 19:20:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52129/
-----------------------------------------------------------

Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Jie Yu.


Repository: mesos


Description
-------

This changes the `ChildHook::SETSID` to a noop on Windows
as there is no equivalent functionality on this OS.

By default, the lifetime of child processes on Windows are not
tied to the parent process (`setsid()` on Posix prevents child
processes from dying when the parent dies).


Diffs
-----

  3rdparty/libprocess/src/subprocess.cpp 6f50a714285cd7bc05d57c476e400a1fa5246796 

Diff: https://reviews.apache.org/r/52129/diff/


Testing
-------

make check (OSX)

In progress: msbuild.exe ... (Windows)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message