mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51560: Deprecated using health checks without setting the type.
Date Wed, 21 Sep 2016 18:18:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51560/
-----------------------------------------------------------

(Updated Sept. 21, 2016, 6:18 p.m.)


Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan Xu.


Changes
-------

Address @xujyan's comments.


Bugs: MESOS-6110
    https://issues.apache.org/jira/browse/MESOS-6110


Repository: mesos


Description
-------

Health checks must supply set type field from now on. Additionally,
`HealthCheck.HTTP` message has been renamed to
`HealthCheck.HttpCheckInfo` to avoid naming collisions.


Diffs (updated)
-----

  docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332 
  src/health-check/health_checker.cpp 758cbb382b08743f518022ba66eaafbea7615592 
  src/tests/health_check_tests.cpp 30b5a2f6b256b795853553f2e5cb3c5e08512a5f 

Diff: https://reviews.apache.org/r/51560/diff/


Testing
-------

Could verfied from https://github.com/haosdent/mesos/blob/85abb6da058bf8daf4e794df7da8eb5f240b671c/docs/upgrades.md


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message