mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.
Date Wed, 21 Sep 2016 17:26:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52092/
-----------------------------------------------------------

(Updated Sept. 21, 2016, 5:26 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.


Repository: mesos


Description
-------

To avoid using `path::join(flags.cgroups_root, containerId.value())` to
concat cgroup internally in subsystems, pass cgroup to the subsystem
interfaces directly. And since containerId is not necessary for the
subsystems anymore, remove it in the subsystem interfaces as well.


Diffs
-----

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp c2fcc0b21c5b1e51cb38b61245d4bbd3856a9512

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 6594110bd45a71c6d41a24b3f5b73c4a4e3a7335

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 05cb8b8efadd2355789d08ce5c9da9d3de0fc72a

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp c1f1004d7578f59dfa9e28323e7a55df41c4cb6b

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 5912c6504a375178b892bf8099d5f75fa9e91c05

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.hpp 10fbbc9cb39a3b41d64cc090b0e890a2416b2306

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.cpp a35ecb073acefb903d7e8c4737d6cd048a2b494d

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp b5d5ed233c0c8ddc339d2550c0f57a02dd3f14c3

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 0afc24867eb0b1949e95b3f5a8914be013dbf531

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp a1c87ce2ace33f1a779e843578f55d7502562c8d

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp bab10ae5d488585603db2637ae15ee02b1982354

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.hpp 16208655e16b81f1e4bbf97bf5e32e75f4c3f3a9

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.cpp 93539f1fc8265f66b62294c22f4eaba704b8b876

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.hpp 5a0adfdb8705ae6b20c61a827380142e418c0ae4

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp cc39f287a64a4125260597e74784dc0847953376


Diff: https://reviews.apache.org/r/52092/diff/


Testing
-------


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message