mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 52091: Replaced `set` to `hashset` in perf interfaces.
Date Wed, 21 Sep 2016 16:51:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52091/
-----------------------------------------------------------

(Updated Sept. 21, 2016, 4:51 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.


Changes
-------

We should not need this after we keep the `ContainerID` in subsystem interfaces.


Repository: mesos


Description
-------

Replaced `set` to `hashset` in perf interfaces.


Diffs
-----

  src/linux/perf.hpp c7dfe0ac4965a450b25085715502f49bee972b5c 
  src/linux/perf.cpp 16a30eac9d346b14f2245128003866b9894bb94a 

Diff: https://reviews.apache.org/r/52091/diff/


Testing
-------

In https://reviews.apache.org/r/52092/, we change from

```
set<string> cgroups;
perf::sample(events, cgroups, flags.perf_duration)
```

to 

```
perf::sample(events, infos.keys(), flags.perf_duration)
```

`infos.keys()` return a `hashset`. So need to change the perf interfaces to use `hashset`
first.


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message