mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45492: Used ChildHooks in Mesos [2/2].
Date Wed, 21 Sep 2016 16:44:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45492/#review149839
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 21, 2016, 3:24 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45492/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 3:24 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-5070
>     https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We now use the new ChildHooks instead of explicit options such
> as setsid.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 49a1b2f7a4d7ef3e40bbfe43834ad9200a35740d 
>   src/health-check/health_checker.cpp 8beb99cb5f2630c3a5a3821b665952f714f53545 
>   src/launcher/posix/executor.cpp 7c40ebebb983b7977526fee123bf07c86fbb5e50 
>   src/linux/perf.cpp 16a30eac9d346b14f2245128003866b9894bb94a 
>   src/slave/container_loggers/lib_logrotate.cpp 1c170e5d11ef31d468b200c2c4cbd27abeeb418a

>   src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
>   src/slave/containerizer/fetcher.cpp 4d3fc521bf8a7c438c48e31c549f108ac3602b3f 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 2b2c6cf2ba35b48e17a169e7a65380889c311266

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 359479083894e887647a694a1a133dce44817073

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 55a06cfe1edbb7699c04101f78cc4979176e33f6

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 3f49b9f5cd4331e54b6f687c31e4304d694ffbc9

>   src/slave/containerizer/mesos/launcher.cpp 73a0e5f50042b1249224a4a42e2442b7ea51dfff

>   src/slave/containerizer/mesos/linux_launcher.cpp 1c49f568b12f5ad688bb43625de3dcbfd618ca79

>   src/tests/containerizer/capabilities_tests.cpp 3ba46404c389385e02d2a1789e33dab3e8f15902

>   src/tests/containerizer/launch_tests.cpp 76d71b3088a7bec3b3f8546c197f65557f464028 
>   src/tests/containerizer/ns_tests.cpp e52ebbe93cd80236ca865a137de4251f25d55b05 
>   src/tests/containerizer/port_mapping_tests.cpp 7fac6ca1550acf54616fb4cef2eab1335f5e9760

> 
> Diff: https://reviews.apache.org/r/45492/diff/
> 
> 
> Testing
> -------
> 
> sudo Make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message