mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45491: Refactored subprocess options [1/2].
Date Wed, 21 Sep 2016 16:42:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45491/#review149838
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 21, 2016, 3:25 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45491/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 3:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-5070
>     https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the subprocess interface supported a several options for the
> child process such as setsid. In order to make the interface more
> flexible we refactored such options into a vector of ChildHooks.
> In order not to allow arbitrary code inside a ChildHook it has to be
> constructed via pre-defined factory methods.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp 1e9a7b9051bb986dbda2a5ad408230a1bf6585f2

>   3rdparty/libprocess/include/process/ssl/gtest.hpp 2ad623a5ea3b3286983e895010af756f14f51b64

>   3rdparty/libprocess/include/process/subprocess_base.hpp 23bc14a30d013e47c4b48782a90523cd0bbb8c14

>   3rdparty/libprocess/src/subprocess.cpp 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 0ff3945d2c722ebc1529265427397c5dfba6854e

> 
> Diff: https://reviews.apache.org/r/45491/diff/
> 
> 
> Testing
> -------
> 
> Tested entire chain see https://reviews.apache.org/r/45492.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message