mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 52017: Renamed Hook to parent Hook in libprocess [1/2].
Date Wed, 21 Sep 2016 15:22:59 GMT


> On Sept. 19, 2016, 12:35 a.m., Qian Zhang wrote:
> > 3rdparty/libprocess/include/process/subprocess_base.hpp, lines 173-176
> > <https://reviews.apache.org/r/52017/diff/1/?file=1501273#file1501273line173>
> >
> >     I think you should remove these code in https://reviews.apache.org/r/52015/
rather than in this patch which is only for renaming.

Thx!


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52017/#review149413
-----------------------------------------------------------


On Sept. 21, 2016, 3:22 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52017/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed Hook to parent Hook in libprocess [1/2].
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp 1e9a7b9051bb986dbda2a5ad408230a1bf6585f2

>   3rdparty/libprocess/include/process/subprocess_base.hpp 23bc14a30d013e47c4b48782a90523cd0bbb8c14

>   3rdparty/libprocess/src/subprocess.cpp 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c 
> 
> Diff: https://reviews.apache.org/r/52017/diff/
> 
> 
> Testing
> -------
> 
> tested entire chain (see 53018).
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message