mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50969: Made use of SSL flags to determine scheduler/executor scheme.
Date Wed, 21 Sep 2016 01:33:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50969/#review149779
-----------------------------------------------------------


Fix it, then Ship it!





src/executor/executor.cpp (lines 36 - 38)
<https://reviews.apache.org/r/50969/#comment217483>

    You don't need to #ifdef the header.  But you do need to #ifdef the _usage_ of the header
:)
    
    Ditto in the other file.


- Joseph Wu


On Sept. 13, 2016, 11:10 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50969/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 11:10 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
>     https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the HTTP scheduler and executor
> libraries to use `process::network::openssl::flags()`
> to determine whether or not SSL is enabled.
> 
> 
> Diffs
> -----
> 
>   src/executor/executor.cpp d1ec817c53d0224a483fec545031016cf90620da 
>   src/scheduler/scheduler.cpp 2ed6ce2a2b61a70a55546e3aeb48b32d90e74ac6 
> 
> Diff: https://reviews.apache.org/r/50969/diff/
> 
> 
> Testing
> -------
> 
> Tested after the following patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message