mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52098: Updated UUID::fromString to not throw an exception on error.
Date Tue, 20 Sep 2016 23:31:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52098/#review149758
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Sept. 20, 2016, 9:24 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52098/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The exception from the string_generator needs to be caught so
> that we can surface a Try to the caller.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/uuid.hpp e638d458c6cb4aaee121a903bb381ccfdeae3fad 
>   3rdparty/stout/tests/uuid_tests.cpp 8f28fcf491e43e87ddd5b54737fd5aef0f6db0a6 
> 
> Diff: https://reviews.apache.org/r/52098/diff/
> 
> 
> Testing
> -------
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message