mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Review Request 52083: Changed reconciliation for unregistering, reregistering agents.
Date Tue, 20 Sep 2016 15:26:17 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Vinod Kone.

Bugs: MESOS-6206

Repository: mesos


Previously, explicit reconciliation for an agent that was in the process
of reregistering or unregistering returned no results. This degree of
cleverness seems unwarranted: if the agent hasn't completed the
reregistration or unregistration process, it seems quite reasonable for
the master to return the previous state of the agent (this is what the
framework would observe if their reconcile request lost the race with
the reregister/unregister, anyway).

Note that since reregistering agents are no longer considered to be "in
transition", we need to slightly adjust the rules for how we update the
`slaves.recovered` collection in the master: an agent remains in the
"recovered" collection until it has been marked reachable in the
registry (rather than removing it from "recovered" as soon as the
reregistration process beings). This is more consistent with how we
manage the other collections in the master anyway.


  src/master/master.hpp 35db198748b8652eb53e17f592f6b40d1e6a3ed9 
  src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851 
  src/tests/master_tests.cpp e6c8362da6a5669e2a2d18f6eb4e454365a84f60 
  src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a 



`make check` on OSX, Linux.


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message