mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.
Date Tue, 20 Sep 2016 15:24:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51880/#review149667
-----------------------------------------------------------




src/tests/containerizer/common_containerizer_tests.cpp (line 96)
<https://reviews.apache.org/r/51880/#comment217330>

    move this to #103



src/tests/containerizer/common_containerizer_tests.cpp (lines 110 - 111)
<https://reviews.apache.org/r/51880/#comment217331>

    new line



src/tests/containerizer/common_containerizer_tests.cpp (lines 112 - 113)
<https://reviews.apache.org/r/51880/#comment217332>

    new line



src/tests/containerizer/common_containerizer_tests.cpp (lines 121 - 122)
<https://reviews.apache.org/r/51880/#comment217333>

    new line



src/tests/containerizer/common_containerizer_tests.cpp (lines 123 - 124)
<https://reviews.apache.org/r/51880/#comment217334>

    new line



src/tests/containerizer/common_containerizer_tests.cpp (lines 146 - 148)
<https://reviews.apache.org/r/51880/#comment217328>

    This maybe not enough, what about the following:
    
    ```
    EXPECT_SOME_EQ(2, resources->cpus());
    EXPECT_SOME_EQ(Megabytes(1024), resources->mem());
    EXPECT_SOME_EQ(Megabytes(1024), resources->disk());
    ```
    
    Ditto for others.



src/tests/containerizer/common_containerizer_tests.cpp (line 235)
<https://reviews.apache.org/r/51880/#comment217348>

    two spaces
    
    ditto for others



src/tests/containerizer/common_containerizer_tests.cpp (lines 235 - 236)
<https://reviews.apache.org/r/51880/#comment217349>

    new line



src/tests/containerizer/common_containerizer_tests.cpp (lines 307 - 308)
<https://reviews.apache.org/r/51880/#comment217335>

    Adjust to make this less jagged.
    ```
    // Resources with cpus, mem and disk (default and
    // PATH disks with a specific size).
    ```



src/tests/containerizer/common_containerizer_tests.cpp (lines 335 - 336)
<https://reviews.apache.org/r/51880/#comment217336>

    Adjust to make this less jagged.
    ```
    // Resources with cpus, mem and disk (default and
    // PATH disks with a specific size).
    ```



src/tests/containerizer/common_containerizer_tests.cpp (lines 368 - 369)
<https://reviews.apache.org/r/51880/#comment217337>

    Adjust to make this less jagged.
    ```
    // Resources with cpus, mem and disk (default and
    // PATH/MOUNT disks with a specific size).
    ```



src/tests/containerizer/common_containerizer_tests.cpp (lines 418 - 419)
<https://reviews.apache.org/r/51880/#comment217347>

    ```
    // Resources with cpus, mem and disk (default and
    // PATH/MOUNT disks with a specific size).
    ```


- Guangya Liu


On 九月 19, 2016, 10:43 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51880/
> -----------------------------------------------------------
> 
> (Updated 九月 19, 2016, 10:43 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
>     https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit tests to determine disk size for MOUNT disks.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 6fb095f58cf943c5597175df695046cfa21b68fd 
>   src/tests/containerizer/common_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51880/diff/
> 
> 
> Testing
> -------
> 
> All tests including the additional tests in this RR passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message