mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized.
Date Tue, 20 Sep 2016 13:11:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52080/
-----------------------------------------------------------

(Updated Sept. 20, 2016, 1:11 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Use a different approach.


Summary (updated)
-----------------

Ensured that `Latch*` in exec, sched drivers is initialized.


Repository: mesos


Description (updated)
-------

In error code paths, this value was previously left uninitialized, which
might subsequently result in attempting to delete an uninitialized
pointer value.


Diffs (updated)
-----

  src/exec/exec.cpp c1cda5aca81dd8c73c50dd01ce49ef69805bbf09 
  src/sched/sched.cpp 6a1a201202b8241e853a821ffcec49187a5bdf35 

Diff: https://reviews.apache.org/r/52080/diff/


Testing
-------

`make check` on OSX.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message