mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yubo Li <liyub...@cn.ibm.com>
Subject Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
Date Tue, 20 Sep 2016 08:37:39 GMT


> On 八月 25, 2016, 7:28 p.m., Kevin Klues wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3893-3894
> > <https://reviews.apache.org/r/50127/diff/7/?file=1480600#file1480600line3893>
> >
> >     I don't understand this comment. Can you clarify? Why do we want to make sure
we are not running in privileged mode?

When docker is running in privileged mode, all host devices are passed into docker by default.
So we can't know which devices are passed by ourselves.


> On 八月 25, 2016, 7:28 p.m., Kevin Klues wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3897-3912
> > <https://reviews.apache.org/r/50127/diff/7/?file=1480600#file1480600line3897>
> >
> >     Why do you do this twice?

The second is for slave's state endpoint. This test will not focus on this, I'll delete it.


> On 八月 25, 2016, 7:28 p.m., Kevin Klues wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3914-3917
> > <https://reviews.apache.org/r/50127/diff/7/?file=1480600#file1480600line3914>
> >
> >     What does this have to do with the GPU test? Do we have to check this here?

I'll delete it. Thanks!


- Yubo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review146841
-----------------------------------------------------------


On 八月 22, 2016, 10:13 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> -----------------------------------------------------------
> 
> (Updated 八月 22, 2016, 10:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 42d4364b6fcbc94c7852721511001c103cb5a90d

> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message