mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.
Date Tue, 20 Sep 2016 05:25:44 GMT


> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote:
> >
> 
> Vinod Kone wrote:
>     also, can you add a test for this?
> 
> Qian Zhang wrote:
>     Sure, I can add a test. I am just wondering how to use a test to verify the logic
we added in this patch, maybe we can just add a test to launch a short task and check `ContainerTermination.status`
is 0 when `Slave::executorTerminated()` is call which means the HTTP command executor has
received the ACK from agent for the terminal status update. Any comments?
> 
> Vinod Kone wrote:
>     That sounds like a good test. Can you add that?

Posted a patch for the test:
https://reviews.apache.org/r/52075/


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46187/#review147808
-----------------------------------------------------------


On Sept. 15, 2016, 4:57 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46187/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 4:57 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5276
>     https://issues.apache.org/jira/browse/MESOS-5276
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Terminate when receiving the ACK of terminal status update.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 5370634ef9e6f3ac9717fed71f6a77707026a16a 
> 
> Diff: https://reviews.apache.org/r/46187/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message