mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.
Date Tue, 20 Sep 2016 05:21:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51631/#review149609
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 302 - 306)
<https://reviews.apache.org/r/51631/#comment217266>

    Hum, i still prefer create Info struct after everything is recovered. You can pass hashset
of subsystem names to `____recover`.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 528 - 548)
<https://reviews.apache.org/r/51631/#comment217264>

    I don't think we need this change because 'isolate' is not goint to be called for old
containers. We only need to do the check for methods that can be potentially called for the
old container.
    
    Plus, you introduced a bug during the conflict resolution.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 569)
<https://reviews.apache.org/r/51631/#comment217265>

    Ditto. No need for this.


- Jie Yu


On Sept. 20, 2016, 4:13 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51631/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 4:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6063
>     https://issues.apache.org/jira/browse/MESOS-6063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recover newly added cgroups subsystems on existing containers would
> fail, and continue to perform the `update` and other operations of
> the newly added subsystems on them don't make sense. This patch add
> the tracking for the recovered or prepared cgroups subsystems of a
> container and skip performing unnecessary subsystem operations on the
> container if the subsystem is never recovered or prepared.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp cf143eef2411b17b775579b1be07c927b64ea835

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 937356b3ef76408bbb01ab699b7a2bd097cdfe82

> 
> Diff: https://reviews.apache.org/r/51631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message