mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.
Date Tue, 20 Sep 2016 00:26:46 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2016, 5:26 p.m.)

Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Rename the ProcessManager termination helper function.  Revise a bunch of comments.

Bugs: MESOS-3910

Repository: mesos


The `SocketManager` and `ProcessManager` are highly inter-dependent, 
which requires some untangling in `process::finalize`.

* Logic originally found in `~ProcessManager` has been split into 
  `ProcessManager::finalize` due to what happens during cleanup.
* The future from `__s__->accept()` must be explicitly discarded as 
  libevent does not detect a locally closed socket.
* Terminating `HttpProxy`s must close the associated socket.

Diffs (updated)

  3rdparty/libprocess/src/process.cpp a6fbf92bd6d69d94490b9faf4960f14aa112e8d2 



`make check` (libev)
`make check` (--enable-libevent --enable-ssl)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message