mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51871: Modified the `isolate` method to be nesting aware.
Date Mon, 19 Sep 2016 23:55:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51871/#review149569
-----------------------------------------------------------



Let's merge the patches into one single patch. These patches are highly related. It's nice
to review them in a single diff.


src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 728)
<https://reviews.apache.org/r/51871/#comment217211>

    Instead of a CHECK, i'd prefer just return Failure here.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 736 - 764)
<https://reviews.apache.org/r/51871/#comment217212>

    I'd combine this with the host network namespace with rootfs case. See my comments in
'prepare' patch.


- Jie Yu


On Sept. 18, 2016, 5:40 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51871/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 5:40 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6156
>     https://issues.apache.org/jira/browse/MESOS-6156
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The network file setup in the `network/cni` isolator is now nesting
> aware. Since the children share the network and UTS namespace with the
> parent, the network files need to be created only for the parent
> container. For the child containers, the network files will be simply
> a symlink to a parents network files.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 359479083894e887647a694a1a133dce44817073

> 
> Diff: https://reviews.apache.org/r/51871/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message