mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Review Request 52069: Moved `CHECK_NE` out of the offers loop.
Date Mon, 19 Sep 2016 22:34:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52069/
-----------------------------------------------------------

Review request for mesos, Abhishek Dasgupta and Vinod Kone.


Repository: mesos


Description
-------

We only need to `CHECK_NE(task.isSome(), taskGroup.isSome())` when
get offers and there is no need to `CHECK_NE` for each offer.


Diffs
-----

  src/cli/execute.cpp f1806723b25c72839475769e85fd7cbe0126d67d 

Diff: https://reviews.apache.org/r/52069/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message