mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52061: Fixed warnings in `duration.hpp`.
Date Mon, 19 Sep 2016 21:16:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52061/#review149548
-----------------------------------------------------------


Fix it, then Ship it!




I'll tweak the spacing before committing.


3rdparty/stout/include/stout/duration.hpp (lines 312 - 313)
<https://reviews.apache.org/r/52061/#comment217186>

    Need 4 spaces for alignment after an open parentheses + newline.  And it would be good
to keep the newline.


- Joseph Wu


On Sept. 19, 2016, 1:04 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52061/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 1:04 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warnings in `duration.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/duration.hpp cd4f205bbfbc4c2647db52fe72f44bd5c8f1c44c

> 
> Diff: https://reviews.apache.org/r/52061/diff/
> 
> 
> Testing
> -------
> 
> Windows: build
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message