mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 52059: Added test for running the logrotate module as non-root.
Date Mon, 19 Sep 2016 19:38:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52059/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan and Sivaram Kannan.


Bugs: MESOS-5856
    https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
-------

This test creates a non-privileged user and but runs the agent
as root.  Logrotate has several branches of logic that are only
exercised as root.  In this case, we expect logrotate to work
if the agent and module are root, but the task is non-root.


Diffs
-----

  src/tests/container_logger_tests.cpp 1b121a2fcce2d874aeefc4257b9d4e594866e78d 

Diff: https://reviews.apache.org/r/52059/diff/


Testing
-------

make check

The new test currently fails (as expected).


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message