mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52031: Added openssl error string output to initializing failures.
Date Mon, 19 Sep 2016 19:34:23 GMT


> On Sept. 19, 2016, 12:02 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/openssl.cpp, lines 509-510
> > <https://reviews.apache.org/r/52031/diff/1/?file=1502587#file1502587line509>
> >
> >     I'd prefer the parentheses containing the `stringify(error)` to mention OpenSSL,
since the number of ambiguous/confusing otherwise.  
> >     
> >     i.e. `(OpenSSL error #___): ...`
> >     
> >     Ditto other error messages.
> 
> Till Toenshoff wrote:
>     I agree, those are confusing. On a second thought, shall we simply remove those error-code-numbers?
I was trying to follow the initial example but now feel we should complete get rid of those
as we can expect the error string to be helpful.

I think the error codes might be useful for debugging.  I'm guessing the error strings may
change between OpenSSL versions (I wonder if there's localization too), but the error codes
will not.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52031/#review149514
-----------------------------------------------------------


On Sept. 19, 2016, 6:13 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52031/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 6:13 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
>     https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds the human readable openssl error messages for failure cases. Also
> fixes a spacing nit in one of the existing messages.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.cpp c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52031/diff/
> 
> 
> Testing
> -------
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message