mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 52053: Return 500 rather than 503 when response handlers fail.
Date Mon, 19 Sep 2016 19:15:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52053/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Libprocess was returning 'Service Unavailable' when an HTTP handler
Future fails. More appropriate would be an 'Internal Server Error'.


Diffs
-----

  3rdparty/libprocess/src/process.cpp a6fbf92bd6d69d94490b9faf4960f14aa112e8d2 
  3rdparty/libprocess/src/tests/http_tests.cpp 24b266df5f17e28e0c95326f5d1ea451952500e8 

Diff: https://reviews.apache.org/r/52053/diff/


Testing
-------

Added a test.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message