-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52031/#review149514
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/openssl.cpp (lines 467 - 468)
<https://reviews.apache.org/r/52031/#comment217178>
And if you decide to add that error code label (see below comment)... this is the only
place that has the same pattern.
3rdparty/libprocess/src/openssl.cpp (lines 509 - 510)
<https://reviews.apache.org/r/52031/#comment217169>
I'd prefer the parentheses containing the `stringify(error)` to mention OpenSSL, since
the number of ambiguous/confusing otherwise.
i.e. `(OpenSSL error #___): ...`
Ditto other error messages.
- Joseph Wu
On Sept. 19, 2016, 6:13 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52031/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 6:13 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
>
>
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds the human readable openssl error messages for failure cases. Also
> fixes a spacing nit in one of the existing messages.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/openssl.cpp c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091
>
> Diff: https://reviews.apache.org/r/52031/diff/
>
>
> Testing
> -------
>
> make check && functional testing
>
>
> Thanks,
>
> Till Toenshoff
>
>
|