mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 52039: Avoided using SIGUSR1 in two test cases.
Date Mon, 19 Sep 2016 14:54:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52039/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

We want to cause the agent to shutdown gracefully (i.e., to send an
"unregister" message to the master). This can be accomplished by sending
the whole process a SIGUSR1 but that seems fragile; using the agent's
`shutdown()` method seems more robust.


Diffs
-----

  src/tests/slave_tests.cpp 696e0f71190238133f29b6380bc58b994a556e69 

Diff: https://reviews.apache.org/r/52039/diff/


Testing
-------

`make check` on OSX.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message