mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 51654: Fixed help display for mesos-containerizer subcommands.
Date Mon, 19 Sep 2016 14:19:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51654/
-----------------------------------------------------------

(Updated Sept. 19, 2016, 4:19 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Repository: mesos


Description
-------

In this patch we add help displays for all current containerizer
subcommands. We also trim existing display of the usage; here we use
that `Flags::usage` already takes care of providing a header.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 359479083894e887647a694a1a133dce44817073

  src/slave/containerizer/mesos/launch.cpp fc51e04ec1572679e6a48ff4f0fa31ef2dfd6ec3 
  src/slave/containerizer/mesos/mount.cpp dbd7853a43ee1402f2f91d933a657010efdd76b0 

Diff: https://reviews.apache.org/r/51654/diff/


Testing
-------

make check

Confirmed by explicitly invoking

    $ mesos-containerizer launch --help
    $ mesos-containerizer mount --help
    $ mesos-containerizer network-cni-setup --help


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message