mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 52020: Fixed indent in allocator.
Date Mon, 19 Sep 2016 14:16:40 GMT


> On 九月 19, 2016, 1:20 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1653
> > <https://reviews.apache.org/r/52020/diff/1/?file=1501903#file1501903line1653>
> >
> >     This looks fine: 4 spaces after '('.

Does the indent always start from begining? 

1) https://github.com/apache/mesos/blob/master/src/cli/execute.cpp#L645-L646
2) https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#function-definitioninvocation


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52020/#review149464
-----------------------------------------------------------


On 九月 19, 2016, 1:59 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52020/
> -----------------------------------------------------------
> 
> (Updated 九月 19, 2016, 1:59 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indent in allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 2d56bd011f2c87c67a02d0ae467a4a537d36867e

> 
> Diff: https://reviews.apache.org/r/52020/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message