mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 51376: Adjusted existing tests to use MockRegistrar.
Date Mon, 19 Sep 2016 13:15:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51376/
-----------------------------------------------------------

(Updated Sept. 19, 2016, 1:15 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Remove unused local variable from test case.


Bugs: MESOS-4049
    https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
-------

This means that `Master::_reregisterSlave` can be made private.


Diffs (updated)
-----

  src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 
  src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 
  src/tests/reconciliation_tests.cpp 8e438bfbce508a074f0d54513cd752344238e3f2 

Diff: https://reviews.apache.org/r/51376/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message