mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 52002: Added helper methods to determine types of disk resources.
Date Mon, 19 Sep 2016 12:41:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52002/#review149440
-----------------------------------------------------------




src/common/resources.cpp (lines 930 - 931)
<https://reviews.apache.org/r/52002/#comment217075>

    ```
    return Error("Resource " + stringify(resource) +
                 " is not a PATH or MOUNT disk");
    ```



src/tests/resources_tests.cpp (lines 2181 - 2196)
<https://reviews.apache.org/r/52002/#comment217104>

    There is no need to define temp variables here, you can refer to https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L1922-L1928
    
    Ditto for the following



src/v1/resources.cpp (lines 932 - 933)
<https://reviews.apache.org/r/52002/#comment217076>

    ```
    return Error("Resource " + stringify(resource) +
                 " is not a PATH or MOUNT disk");
    ```


- Guangya Liu


On 九月 19, 2016, 5 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52002/
> -----------------------------------------------------------
> 
> (Updated 九月 19, 2016, 5 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6062
>     https://issues.apache.org/jira/browse/MESOS-6062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper methods to determine types of disk resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 3ef8cacee529addc745b4aeb6398d7606c61b749 
>   include/mesos/v1/resources.hpp ef56b4960b103a3efd916fab64796aa334ba44c6 
>   src/common/resources.cpp 4602bff22ec7ff77f069056085ad92bfa04595f3 
>   src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a 
>   src/v1/resources.cpp 7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6 
> 
> Diff: https://reviews.apache.org/r/52002/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message