mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51623: Updated mesos-execute to support task groups.
Date Mon, 19 Sep 2016 03:40:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51623/#review149427
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51978, 51991, 51990, 51623]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 18, 2016, 9:11 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51623/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 9:11 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
>     https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated mesos-execute to support task groups.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 
> 
> Diff: https://reviews.apache.org/r/51623/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4
> 
> and manually ran this command:
> **Successful**
> mesos-execute --master=127.0.0.1:5050 --taskgroup=file:///home/abhishek/taskgroup.txt
> 
> `/home/abhishek/taskgroup.txt:`
> {
> 	"tasks": [{
> 		"name": "sigmtdroid",
> 		"task_id": {
> 			"value": "sigmoid"
> 		},
> 		"agent_id": {
> 			"value": ""
> 		},
> 		"resources": [{
> 			"name": "cpus",
> 			"type": "SCALAR",
> 			"scalar": {
> 				"value": 1
> 			},
> 			"role": "*"
> 		}, {
> 			"name": "mem",
> 			"type": "SCALAR",
> 			"scalar": {
> 				"value": 32
> 			},
> 			"role": "*"
> 		}],
> 		"command": {
> 			"value": "sleep 1000"
> 		},
> 		"volumes": [{
> 			"container_path": "/mnt/volume",
> 			"mode": "RW",
> 			"source": {
> 				"docker_volume": {
> 					"driver": "volume_driver",
> 					"docker_options": {
> 						"parameter": [{
> 							"key": "key",
> 							"value": "value"
> 						}]
> 					},
> 					"name": "volume_name"
> 				},
> 				"type": "DOCKER_VOLUME"
> 			}
> 		}]
> 	}, {
> 		"name": "sigmteroid",
> 		"task_id": {
> 			"value": "sigmoid2"
> 		},
> 		"agent_id": {
> 			"value": ""
> 		},
> 		"resources": [{
> 			"name": "cpus",
> 			"type": "SCALAR",
> 			"scalar": {
> 				"value": 2
> 			},
> 			"role": "*"
> 		}, {
> 			"name": "mem",
> 			"type": "SCALAR",
> 			"scalar": {
> 				"value": 32
> 			},
> 			"role": "*"
> 		}],
> 		"command": {
> 			"value": "sleep 1000"
> 		},
> 		"volumes": [{
> 			"container_path": "/mnt/volume",
> 			"mode": "RW",
> 			"source": {
> 				"docker_volume": {
> 					"driver": "volume_driver",
> 					"docker_options": {
> 						"parameter": [{
> 							"key": "key",
> 							"value": "value"
> 						}]
> 					},
> 					"name": "volume_name"
> 				},
> 				"type": "DOCKER_VOLUME"
> 			}
> 		}]
> 	}]
> }
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message