mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 50960: Added appc uri fetcher tests.
Date Mon, 19 Sep 2016 03:35:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50960/
-----------------------------------------------------------

(Updated Sept. 19, 2016, 3:35 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
    https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
-------

Added tests to fetch using all three modes that 'rkt fetch' supports,
fetch with meta discovery  ex: 'coreos.com/hello:latest',
fetch from a specific  location ex: 'https://github.com/xxx/hello.aci'
fetch from docker registry ex: 'docker://hello-world'.


Diffs (updated)
-----

  src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b 

Diff: https://reviews.apache.org/r/50960/diff/


Testing (updated)
-------

make check

Found issue that the tests would fail if "rkt" binary is not available. Please suggest if
I should use some environment variable to selectively run the tests under __IF_DEFINED_RKT


Thanks,

Srinivas Brahmaroutu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message