mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 52004: Supported docker runtime isolator to be nested aware.
Date Mon, 19 Sep 2016 03:14:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52004/#review149421
-----------------------------------------------------------



Ditto for appc run time isolator here: https://reviews.apache.org/r/52005/


src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 140 - 141)
<https://reviews.apache.org/r/52004/#comment217041>

    s/info/command info 
    
    this can be more accurate.



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 231 - 235)
<https://reviews.apache.org/r/52004/#comment217043>

    What about merging this with #138 - #142 after update? Seems most of the comments are
related to that.



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 235)
<https://reviews.apache.org/r/52004/#comment217038>

    Nit: s/neccessary/necessary


- Guangya Liu


On 九月 18, 2016, 5:30 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52004/
> -----------------------------------------------------------
> 
> (Updated 九月 18, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6190
>     https://issues.apache.org/jira/browse/MESOS-6190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker runtime isolator to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp ac0397f65bb2a675ad1eae0f7cfa95f10145fc63

>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp b589cd691ae6aacd2dcd00878e43d58f15abfe11

> 
> Diff: https://reviews.apache.org/r/52004/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message