mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
Date Mon, 19 Sep 2016 01:15:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
-----------------------------------------------------------

(Updated Sept. 19, 2016, 1:15 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
    https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
-------

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with
meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
registry ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new
AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
fetch a container image into a store specified at a directory location
using 'rkt fetch' command and method 'rktExport' exports the image
fetched into the directory location as a '.aci' file that is in tar
file format, usinf 'rkt image export' command.


Diffs (updated)
-----

  src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
  src/uri/fetchers/rkt.hpp PRE-CREATION 
  src/uri/fetchers/rkt.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
-------

make check


Thanks,

Srinivas Brahmaroutu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message