mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52012: Reverted "Added extra functions to the 'Launcher' abstraction.".
Date Sun, 18 Sep 2016 22:54:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52012/#review149402
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 18, 2016, 6:31 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52012/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 6:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6204
>     https://issues.apache.org/jira/browse/MESOS-6204
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This reverts commit bb047cd72936aa1836b6e959127a572c72fb824b.
> 
> We decided to revert this commit in favor of keeping all container
> checkpointing information in the containerizer. A subsequent commit
> will reintroduce this functionality there.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launcher.hpp 61c2e84a3cebc308a8a65e536fa07fa1cf8f5838

>   src/slave/containerizer/mesos/launcher.cpp 73a0e5f50042b1249224a4a42e2442b7ea51dfff

>   src/slave/containerizer/mesos/linux_launcher.hpp dca827cba4d1ead90dba036c9b94ba5e3a3f82fe

>   src/slave/containerizer/mesos/linux_launcher.cpp 1c49f568b12f5ad688bb43625de3dcbfd618ca79

>   src/tests/containerizer/launcher.hpp f87b3ce92c6a5d996995833d79c976db6afe2700 
> 
> Diff: https://reviews.apache.org/r/52012/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message