mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51720: Updated tests to properly set 'flags.launcher' with correct value.
Date Sun, 18 Sep 2016 22:36:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51720/#review149396
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 18, 2016, 6:10 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51720/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 6:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-6141
>     https://issues.apache.org/jira/browse/MESOS-6141
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In some of our tests we manually create a 'PosixLauncher' rather than
> relying on the value of 'flags.launcher' to decide which type of
> launcher to create. Since calls to 'CreateSlaveFlags()' set
> 'flags.launcher' to 'linux' by default, there was a discrepency in
> what the flags said, and what actual launcher type we were creating.
> 
> This commit fixes this to explicitly set 'flags.launcher' to the
> appropriate type.
> 
> 
> Diffs
> -----
> 
>   src/tests/container_logger_tests.cpp c8497c9d4253e30a0b1bcd31b27a64255961931e 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 96e24500a12825161553eb050da389088b122695

> 
> Diff: https://reviews.apache.org/r/51720/diff/
> 
> 
> Testing
> -------
> 
> $ GTEST_FILTER="" make -j check
> $ src/mesos-tests
> $ sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message