mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52007: Updated 'parseExecutorRunPath()' for nested sandbox support.
Date Sun, 18 Sep 2016 21:41:19 GMT


> On Sept. 18, 2016, 9:36 p.m., Jie Yu wrote:
> > src/slave/paths.cpp, line 106
> > <https://reviews.apache.org/r/52007/diff/1/?file=1501155#file1501155line106>
> >
> >     I'd add a comment here, explaining the layout:
> >     ```
> >     For a nested container x.y.z, the sandbox layout is the following:
> >     .../runs/x/.containers/y/.containers/z
> >     ```

In fact, a second thought on this. For a nested container x.y.z, can we use the following
layout consistently:
```
.../runs/x/.containers/x.y/.containers/x.y.z/
```


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52007/#review149387
-----------------------------------------------------------


On Sept. 18, 2016, 5:31 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52007/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 5:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6191
>     https://issues.apache.org/jira/browse/MESOS-6191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated 'parseExecutorRunPath()' for nested sandbox support.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ea418252956c8089acc5a491888ed7f6df6cafcd

>   src/slave/paths.hpp ebff3a9fab3f4a8d38502fe02bd5a34cf95c1830 
>   src/slave/paths.cpp eb414caae5847949854743d4e3c603217a897898 
>   src/tests/paths_tests.cpp 0671ee25b484cacf08c9a20ee6eba88e6f14fa97 
> 
> Diff: https://reviews.apache.org/r/52007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message