mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.
Date Sun, 18 Sep 2016 00:10:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/#review149351
-----------------------------------------------------------



A rebase is needed.


src/cli/execute.cpp (line 512)
<https://reviews.apache.org/r/51978/#comment216901>

    Since you are doing a refactor, it is better to also set this parameter as `const Option<vector<Volume>>&
volumes` as the `volumes` is also an option value. With updating here, you may also want to
update Line 764 as well.


- Guangya Liu


On 九月 17, 2016, 4:23 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51978/
> -----------------------------------------------------------
> 
> (Updated 九月 17, 2016, 4:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
>     https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This refactoring was needed for better accomodating pod support
> for mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
> 
> Diff: https://reviews.apache.org/r/51978/diff/
> 
> 
> Testing
> -------
> 
> Manually Ran:
> mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" --docker_image="ubuntu"
--containerizer="docker"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message