mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 51992: Fixed a bug in getRootContainerId due to protobuf copying issue.
Date Sat, 17 Sep 2016 21:26:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51992/#review149347
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Sept. 17, 2016, 9:25 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51992/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It looks like protobuf is not so great dealing with nesting messages
> when doing merge or copy. This patch uses an extra copy to bypass that
> issue in the protobuf.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/utils.hpp 2bb55c19bcbfcdfff15930d0f9e437a502ce6624 
> 
> Diff: https://reviews.apache.org/r/51992/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message