mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51988: Updated 'cgroups' isolator 'watch' to be properly nested aware.
Date Sat, 17 Sep 2016 20:01:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51988/#review149345
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 17, 2016, 7:47 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51988/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2016, 7:47 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6186
>     https://issues.apache.org/jira/browse/MESOS-6186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a previous iteration of attempting to make this isolator nested
> aware, we (incorrectly) decided to return a 'Failure()' in 'watch()'
> for nested containers. However, we shouldn't just blindly fail this
> call for nested containers. Instead we should just return a 'Future'
> that will never be satisfied. This way it is safe to call 'watch()'
> for nested containers, without any unwanted side effects.
> 
> This commit fixes this issue.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp ed7150a9b53c577fc248f8af2be55c6b12f64303

> 
> Diff: https://reviews.apache.org/r/51988/diff/
> 
> 
> Testing
> -------
> 
> $ GTEST_FILTER="" make -j check
> $ sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message