-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51975/#review149293
-----------------------------------------------------------
include/mesos/slave/isolator.hpp (line 44)
<https://reviews.apache.org/r/51975/#comment216853>
s/supportNesting/supportsNesting/
Ditto all the way through.
Also, can you add a comment about exactly what this function refers to, i.e. that it is
designed to allow isolators to opt-in to support nested containers.
- Kevin Klues
On Sept. 16, 2016, 10:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51975/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2016, 10:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues.
>
>
> Bugs: MESOS-6186
> https://issues.apache.org/jira/browse/MESOS-6186
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a virtual function to Isolator to tell is it supports nesting.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp d5880eee3c8aee3555630afd21bdd6af5854d11b
> src/slave/containerizer/mesos/isolator.hpp b94947bc5e83b4f2a2174cb21ed559b4241d2c0a
> src/slave/containerizer/mesos/isolator.cpp 253ff3cea8aff3e7a3051fb5a763cc081f455f18
>
> Diff: https://reviews.apache.org/r/51975/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
|