mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 51968: Simplified usage of `os::pagesize` in Mesos.
Date Fri, 16 Sep 2016 20:11:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51968/#review149250
-----------------------------------------------------------


Ship it!




LGTM!

- Joseph Wu


On Sept. 16, 2016, 12:02 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51968/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 12:02 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simplified usage of `os::pagesize` in Mesos.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/lib_logrotate.hpp 9f8ec2f2258fbd5d70f8db466bc71856c568a58d

>   src/slave/container_loggers/logrotate.hpp 96697d46ca71e7f62119f2fe669230cf5a04242f

> 
> Diff: https://reviews.apache.org/r/51968/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX and Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message