mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.
Date Fri, 16 Sep 2016 19:16:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51965/#review149244
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 372)
<https://reviews.apache.org/r/51965/#comment216804>

    does this compile?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 509 - 514)
<https://reviews.apache.org/r/51965/#comment216805>

    Can we factor out this into a helper in `src/slave/containerizer/mesos/utils.hpp`. I imagine
a lot of isolator will use that.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 538)
<https://reviews.apache.org/r/51965/#comment216806>

    WHy not just short circuit above the for loop?


- Jie Yu


On Sept. 16, 2016, 7:10 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51965/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-6186
>     https://issues.apache.org/jira/browse/MESOS-6186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the generic 'cgroups' isolator to be nested container aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp e87d055a44041735b62afd94aebcedf0f38a71bb

> 
> Diff: https://reviews.apache.org/r/51965/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message