mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 51623: Updated mesos-execute to support task groups.
Date Fri, 16 Sep 2016 18:59:39 GMT


> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote:
> > src/cli/execute.cpp, lines 117-121
> > <https://reviews.apache.org/r/51623/diff/1/?file=1490738#file1490738line117>
> >
> >     We want to add support for running multiple containers with different images,
not just multiple commands! For example we want to be able to run docker images 
> >     "redis" and "nginx" as a group.
> >     
> >     In other words each task could potentially have different values for name, shell,
command, environment, resources, appc_image, docker_image, volumes.
> >     
> >     I propose as follows:
> >     
> >     ```
> >     --taskgroup="{..JSON string}"
> >     ```
> >     
> >     Parse this into `TaskGroupInfo`
> 
> Abhishek Dasgupta wrote:
>     Ok, got it. But in this case do we need to keep old name, shell, command, environment,
resources, appc_image, docker_image, volumes options as well?? And if we keep, then our logic
should be if --taskgroup is present, ignore all other name, shell, command, environment, resources,
appc_image, docker_image, volumes options. Just need to confirm this approach.
> 
> Vinod Kone wrote:
>     yes, lets keep the other flags for backwards compatibility. and correct if "taskgroup"
is specified others shouldn't be.
> 
> Avinash sridharan wrote:
>     Instead of taking a JSON string as an input to --taskgroup, can we take a JSON file
as an input? It will become a pain for users to give entire JSON strings on the command line,
given that taskgroups will be relatively verbose.
> 
> Vinod Kone wrote:
>     sure. or we can allow both as we do in mesos.
> 
> Avinash sridharan wrote:
>     +1

In the latest revision, provision for both is there.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51623/#review148188
-----------------------------------------------------------


On Sept. 16, 2016, 6:58 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51623/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 6:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
>     https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated mesos-execute to support task groups.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
> 
> Diff: https://reviews.apache.org/r/51623/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4
> 
> and manually ran this command:
> **Successful**
> mesos-execute --master=127.0.0.1:5050 --taskgroup=file:///home/abhishek/taskgroup.txt
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message