mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <>
Subject Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.
Date Fri, 16 Sep 2016 16:21:43 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 16, 2016, 4:21 p.m.)

Review request for Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.


Added checks to ensure that `container_info` is set for child containers, and that their `NetworkInfo`
is not set. Setting `NetworkInfo` in `container_info` for a child container implies that parent
and child have different network namespaces which is not currently supported.

Bugs: MESOS-6156

Repository: mesos


Modified the `prepare` method to be aware of nested containers.

Diffs (updated)

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 822f11eab5b00c014563322a8c3b2c14cb440e0b



make check
sudo ./bin/

The only tests that failed were the SUDO make check tests:
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Listen
[  FAILED  ] CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreaseRSS
[  FAILED  ] LinuxFilesystemIsolatorTest.ROOT_RecoverOrphanedPersistentVolume


Avinash sridharan

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message